ABCDEFGHIJKLMNOPQRSTUVWXYZ
1
2
3
4
5
Milestone Review for Funded Projects
6
7
Project Name:scs substraTEE
8
Proposal Link:https://polkadot.polkassembly.io/post/111#cae2bc3b-4889-4af5-8725-5aa9d7145b55
9
Milestone:M8.2
10
Repository or Pull Requests:https://github.com/scs/substraTEE-worker/tree/sidechain-M8.2
11
Delivery Documentation or Report:https://github.com/scs/substraTEE-book/blob/sidechain-M8.2/src/howto_direct_tx.md
12
Reviewer:shamb0
13
Reviewer Address:14Ger24FeQunPmP4KJsxFHCrxHSrp5yJqT2E1JQbfZoDsxkw
14
Status:COMPLETED
15
16
17
1. General Notes
18
19
Requirements, Instructions or Process
20
Describe the process to replicate and execute the delivered milestone, or the steps you follow to test this.
21
Accept extrinsics directly over RPC | SGX SW mode using docker runtime | https://www.substratee.com/howto_direct_tx.html
22
23
StepsStatus
24
Install docker imagePasseddocker image id :: scssubstratee/substratee_dev:1804-2.12-1.1.3-001
25
launch docker runtimePasseddocker runtime in interactive mode, and all below steps are executed inside docker context.
26
Generate worker & client binary from substraTEE-worker from branch sidechain-M8.2Passedbranch sidechain-M8.2 | build diversity SGX_MODE=SW
27
Generate substrate node binary from substraTEE-node branch sidechainPassedbranch sidechain
28
Launch generated substratee-node PassedAble to see blocks being produced.
29
Create crypto keys using substartee-workerPassedFollowing Local keystore files are generated, spid.txt key.txt, ~/mrenclave.b58
30
Launch generated substratee-workerPassedWorker is launched in '--skip-ra' mode, and able to see blocks being synced.
31
Launch client using direct invocation scriptPassed./demo_direct_call.sh | Transaction account balance status looks OK.
32
substratee-worker Unit testPassed"substratee-worker test --unit"
33
Run enclave ecall testsOtherOutof Scope
34
Run integration testsOtherOutof Scope
35
36
2. Commits
37
Look at the commits and lines of code in the delivery that have changed before the completion of the milestone: is the functionality proposed in the original on-chain submission implemented?YES
38
64 commits, 58 changed files, +5,605, -4,406 | https://github.com/scs/substraTEE-worker/compare/M8.1...sidechain-M8.2
39
40
CommitsNotes
41
scs/substraTEE-worker@7ce3b73Sidechain m8.1 fixes (#201)
42
scs/substraTEE-worker@6ad5061Sidechain m8.2 unittesting (#203)
43
scs/substraTEE-worker@4a37208add interval loop
44
scs/substraTEE-worker@a207486
move sync chain relay to interval execution
45
scs/substraTEE-worker@6f509daremove WorkerCallFn
46
scs/substraTEE-worker@d2c5685rename sync chain relay
47
scs/substraTEE-worker@a7b34e6add new block type struct
48
scs/substraTEE-worker@b3affb6change xt to block
49
scs/substraTEE-worker@4f3e07benable direct invocation again
50
scs/substraTEE-worker@103ce6dadd construct block function
51
scs/substraTEE-worker@d1ea3a4add verify signature to block struct
52
scs/substraTEE-worker@70f0da8add unittests to block struct
53
scs/substraTEE-worker@6654656add read access functions for block
54
scs/substraTEE-worker@36a2043fix unittests
55
scs/substraTEE-worker@4a81c2fadd get signature unittest
56
scs/substraTEE-worker@6c21427
rename produce_block to produce_blocks
57
scs/substraTEE-worker@ca0b377some clean up
58
scs/substraTEE-worker@2043e06
remove unnecessary author argument from construct_block()
59
scs/substraTEE-worker@d8f9b5f
readd chunk block size to produce block ecall
60
scs/substraTEE-worker@61fcf6cadd stf function get block number
61
scs/substraTEE-worker@7de72d7remove dead code
62
scs/substraTEE-worker@fb25cb2first steps towards new block creation
63
scs/substraTEE-worker@08b4da2
add new block structure proposal. Needs some more think-through
64
scs/substraTEE-worker@8e38ffc
update to new sgx-externalities sidechain branch
65
scs/substraTEE-worker@3ce1867minor changes
66
scs/substraTEE-worker@0d04d05
bug fix & add check time overude function
67
scs/substraTEE-worker@e79f00a
add time check after every getter and call execution
68
scs/substraTEE-worker@8d9b13badd time out unit tests
69
scs/substraTEE-worker@5980b0e
reorder load and write state for each shard only once
70
scs/substraTEE-worker@1745bbd
make state update available for block production
71
scs/substraTEE-worker@6c7db54
move timeout constants to constants.rs
72
scs/substraTEE-worker@51472a1
new block structure (signed block - block - encrypted payload)
73
scs/substraTEE-worker@33f5d8alittle clean up
74
scs/substraTEE-worker@d9f34fcadd last block hash to stf
75
scs/substraTEE-worker@28bc94eadd block composition function
76
scs/substraTEE-worker@1942efc
change call hash to hash of trusted call signed insted of opaque call
77
scs/substraTEE-worker@ac17d0c
add genesis hash and number to init state
78
scs/substraTEE-worker@3f1fc38some clean up
79
scs/substraTEE-worker@45188fbadd state unit tests
80
scs/substraTEE-worker@4b3b589compose opaque call from extrinsic
81
scs/substraTEE-worker@6b0e5b2
add signed block to return value of block execution (needed for blockā€¦
82
scs/substraTEE-worker@a0d44ccremove unnecessary genesis inits
83
scs/substraTEE-worker@830b611add debugging helpers
84
scs/substraTEE-worker@7ef1d5fadd clean up after state unit tests
85
scs/substraTEE-worker@1944725make unittest block confimration work
86
scs/substraTEE-worker@ae211ae
replace sgx error with 0 when getting block number
87
scs/substraTEE-worker@bf4cd04change stf Signature from Any to Multi
88
scs/substraTEE-worker@05913f9add From function to KeyPair wrapper
89
scs/substraTEE-worker@ecde53dadd submit top to pool unit tests
90
scs/substraTEE-worker@3d12f47
add unit test differentiate getter and call in top pool
91
scs/substraTEE-worker@554ff1abug fix
92
scs/substraTEE-worker@bc4a871
add unit test create block and confirmation works
93
scs/substraTEE-worker@b01b851adaption to block confirm of node
94
scs/substraTEE-worker@4cdc5d7add ocall to worker for signed block
95
scs/substraTEE-worker@1ed0204some clean up
96
scs/substraTEE-worker@73859abbug fix of return value to client
97
scs/substraTEE-worker@90e9ca1
Merge pull request #216 from scs/sidechain-M8.2-getter-fix
98
scs/substraTEE-worker@f5f43daadd error message
99
scs/substraTEE-worker@1d63051add proper error handling
100
scs/substraTEE-worker@394593c
decline top pool commits without existing shard