[QA] Platform Issues
 Share
The version of the browser you are using is no longer supported. Please upgrade to a supported browser.Dismiss

View only
 
ABCDEFGH
1
issuetypedatecomponentlinedesccommentsstatus
2
32091J42/5/2016AddPaymentOrderInvoicesTransformerNew methods getOrderByClauses and appendOrderByClauses are protected, they could be privatereviewed
3
32091F42/5/2016AddPaymentOrderInvoicesTransformerOld getOrderByClause and appendOrderByClause are no longer usedreviewed
4
32091G212/5/2016Sorting grid without any filtering applied, does not keep selection on topreviewed
5
31766UX12/10/2016Set proper title to selectorreviewed
6
32110G242/10/2016fop.jarBy convention it should be named fop-1.1.jarreviewed
7
32282G192/19/2016DatabaseValidatorDo not add more exceptional code, maitain a white list for this purposereviewed
8
32231G32/19/2016DefaultDataSourceServiceNull case is not checked causing NPEreviewed
9
32429L23/8/2016Missing context in logreviewed
10
32429G123/8/2016Weired ifreviewed
11
32460G53/18/2016duplicated variable definition in build.xmlreviewed
12
32460L33/18/2016missing logreviewed
13
32460G33/18/2016reviewed
14
32584G244/6/2016TestFetchDSNoActiveEntity
WSWithNoActiveEntityTest
"Entity" name is incorrectly usedreviewed
15
32584C44/6/2016TestFetchDSNoActiveEntity
WSWithNoActiveEntityTest
Gramatically incorrect "cases for ensures that fetch works"reviewed
16
32584N34/6/2016TestFetchDSNoActiveEntity
WSWithNoActiveEntityTest
Follow conventions to name test classes andd methodsok,reviewed
17
32584G94/6/2016TestFetchDSNoActiveEntityOBContext.getOBContext().getRole(); is not usedreviewed
18
32584G204/6/2016TestFetchDSNoActiveEntity.fetchNoActiveOrganizationIt also fetches activereviewed
19
32584T114/6/2016TestFetchDSNoActiveEntityTest should be split in 2: active/inactivereviewed
20
32584G124/6/2016TestFetchDSNoActiveEntity* adminMode no needed for fecthing (might be for updating)
* why commit in the finally?
reviewed
21
32584T124/6/2016TestFetchDSNoActiveEntityMessage says "Request" where it should be "response"reviewed
22
32584T124/6/2016TestFetchDSNoActiveEntityMessage says "request data" where it should be "response data length"reviewed
23
32584T104/6/2016WSWithNoActiveEntityTestUsing hamcrest to emulate assertTruereviewed
24
32584T34/6/2016WSWithNoActiveEntityTestWhat about fetching active element?reviewed
25
32605G55/4/2016QueryListDataSourceDuplication of statement: hqlWithoutOrderByClause.toLowerCase()reviewed
26
32627B514/4/2016reviewed
27
32321C229/4/2016Class removed but comments with links to it still presentreviewed
28
32795G126/5/2016EntityAccessCheckerUnneded if:
if (!list.isEmpty()) {
for (e:list) {..}
}
reviewed
29
32819B16/5/2016QueryListDataSourceNot introduced by this fix for this issue, but looking at the sorrounding code found:
String id1; String id2;
..
if (id1==id2){...}
Though it was working fine because finally it was always the same String instance, it makes the code harder to understand
reviewed
30
32870L26/5/2016HSASMissing context inforeviewed
31
32870L06/5/2016HSASlogged message is ok for UI: "With your role you..." but not so much for log, it'd be better st like "Role X tried to access ungranted resource Y"reviewed
32
32870L36/5/2016HSASDemote level from error to warnreviewed
33
32912G1211/5/2015EmptyStringWhereAndFilterClauseParameterUse private class to generate params mapreviewed
34
32912SC011/5/2015EmptyStringWhereAndFilterClauseParameterUse warehouse entity to make tests more securereviewed
35
32912G2511/5/2015EmptyStringWhereAndFilterClauseParameterUse constant for windowId and tabIdreviewed
36
32769G511/5/2016DataSourceServletDuplicate value for window with windowToCsv reviewed
37
32769G1211/5/2016DataSourceServletDo not use keyValue.toString().equals("true"), cast value to Boolean and use it in the if clausedone: if ((Boolean) keyValue) {reviewed
38
32769G1211/5/2016DataSourceServletPrecalculate translatableValues, do not use Utility.messageBD inside the loopmove to QueryJSONWriterToCSVreviewed
39
32769N111/6/2016DataSourceServletchange name of method getValueShouldCheckTranslationPreferencetranslateBooleanPropertiesInCsvreviewed
40
32769B011/6/2016AD_REF_LIST.xmlMove preference from Core to JSON Datasource moduleOBSERDS_CSVExportTranslateYesNoReferencereviewed
41
32769G1211/6/2016DataSourceServletuse a method to identify Yes/No reference. Use getColumnId() of the property to reach the column. Get reference Id used by the column --> If it is equal to Yes/No then return true.reviewed
42
32769G1211/6/2016DataSourceServletcreate a list to keep yesNoColumns --> use it to indentify yesno properties in write() methodreviewed
43
32769G1211/6/2016DataSourceServletCreate two methods getTranslatedLabelYes() and getTranslatedLabelNo() to avoid querying for labels multiple times reviewed
44
32769G1211/6/2016DataSourceServletdeclare translateYesNoReferences inside the constructorreviewed
45
32769G1211/6/2016DataSourceServletNested if line 647: if (shouldCheckTranslation) {reviewed
46
33052N111/6/2016ReturnFromCustomerPickAndEditHQLTransformerIt affects also to Return to Vendorreviewed
47
33052C66/16/2016ReturnFromCustomerVendorPropertyFieldsTransformerreviewed
48
33052G56/16/2016PROPERTY_FIELD_SEPARATOR defined in 2 placesreviewed
49
33052D26/16/2016Tab currentTab = OBDal.getInstance().get(Tab.class, tabId); used only in query, it should be a proxyreviewed
50
33052G126/16/2016 Table table = tab.getTable();
if (table != null ...
table cannot be null here
reviewed
51
33052G96/16/2016
https://code.openbravo.com/erp/devel/try/rev/539d483a658d#l4.66
tabId parameter was not set, so the whole block was never executedreviewed
52
33003N87/8/2016formatedPropKey -> formattedPropKeyreviewed
53
33003G127/8/2016formattedPropKey no need to initialize with empty value if it always gets initializedreviewed
54
33639G2523/8/2016UpdateInvariantCharacteristicsHandlerReplace -1 with constant (i.e. NO_SUBSET)reviewed
55
33572PR330/8/2016c_poc_doctype_template_trgIt should not be executed for deletion
In update it should only be executed for isDefault columne
C_POC_DOCTYPE_TEMPLATE_TRG is executed for each statement instead of for each row, so it is not possible to use NEW/OLD to know if the isDefault column has changed.reviewed
56
33775G230/8/2016The patch fixes creating new from quick launch menu, but the issue is still reproducible when the new record is created from recent views menu.reviewed
57
33900L29/9/2016NumberUIDefinitionOn exception, columnname is logged but no info about in which window it happenedreviewed
58
33900G29/9/2016It works as expected for String literals defaults but it does not for defaults got from SQLreviewed
59
33799G514/9/2016ob-standard-viewAvoid double call to OB.PropertyStore.get(this.sessionAttributesNames[i], this.standardWindow.windowId)
Use a new variable to keep the value --> preferenceValue

reviewed
60
33799G2114/9/2016ob-standard-viewAssignment placed outside of the for loopreviewed
61
34043L228/08/2016SimpleCallout210Add context informtation for the error log --> "Error retrieving combo entries for field " + param is much more descriptivereviewed
62
34043G328/08/2017SimpleCallout207What happens if result.getJSONObject(param) is not null but it does not have entries?reviewed
63
34043B428/08/2017SimpleCallout246Suggestion: "The id of the combo entry to be removed"

- Removes an entry of the combo field

The same for the javadoc of the addSelectResult method

- Adds an entry value to the combo field.
- The id of the combo entry to add
- The identifier of the combo entry to add

Fix also:

Starts the inclusion of values of a field named param of type select --> Starts the inclusion of values to the combo field with the name passed as parameter

reviewed
64
34043L228/08/2018SimpleCallout274Add context informtation for the error log
"Error adding combo entry with id "+id+ "and identifier " + identifier +" for combo field " + currentElement


Add id and identifier in the error so the context information is more even more descriptivereviewed
65
34043C128/08/2019SimpleCallout282Comment is saying "If any entry is marked as selected for currentElement combo" but next line is checking the oppositereviewed
66
34180G219/10/2016AD_LANGUAGE_CREATE594M_Offer_Type_Trl.Description column is not populatedreviewed
67
33659B424/10/2016CheckIndexFunctionInPrescriptsTest case to ensurereviewed
68
33659C124/10/2017CheckIndexFunctionInPrescriptsThe javadoc of the class does not explain what the test really doesRemovedreviewed
69
33659C224/10/2018CheckIndexFunctionInPrescriptsComment of method createNewIndexFunctionInPrescript() is not correct. the method is not doing what the comment is explainingChange method name to "isFunctionIndexExportedProperly" and removed commentsreviewed
70
33659C324/10/2019CheckIndexFunctionInPrescriptswgy using dropIndexFunction() method? If it is necessary to test this, then create a separate test methodMoved to @After methodreviewed
71
33659N124/10/2020OracleModelLoader.removeDatabaseName325Replace all ocurrences of databaseName with databaseOwnerreviewed
72
33659C424/10/2020OracleModelLoader.removeDatabaseNamecomment does not give any value. Missing parameters infoBy naming the method as follows: removeDatabaseOwnerFromIndexExpression the javadoc cn be removed as the method would be self-explanatoryreviewed
73
33659G324/10/2021OracleModelLoader.removeDatabaseNameWhat if databaseName is null ---> in that case return indexExpression without changesdatabaseOwner != null reviewed
74
33659G1624/10/2022OracleModelLoader.removeDatabaseNameUse this code, it is easier to understand:
String dbPrefix = databaseOwner+"."
if (indexExpression.startsWith(dbPrefix)) {
return indexExpression.substring(dbPrefix.length());
}





reviewed
75
33659B225/10/2023CheckIndexFunctionInPrescriptsNot working on PostgreSQLreviewed
76
34267SC028/10/2016Security concerns about current implementation discussed with MTAreviewed
77
34486G325/11/2016When stateless ws call is performed, no record is added to AD_Session. This causes counting ws calls to be incorrect.reviewed
78
34331C725/11/2016AllowedCrossDomainsHandlerWhy is it Apache licencense?reviewed
79
34331J425/11/2016AllowedCrossDomainsHandler.isAllowedOrigincan be privatereviewed
80
3433125/11/2016
AllowedCrossDomainsHandler.AllowedCrossDomainsChecker
Add @SessionScoped anotation so by default sublcasses inherit it alsoreviewed
81
34462G202/12/2016In application menu still old icon appearsreviewed
82
33853G216/12/20161. Open a window without any summary fucntion
2. Move any column in grid to another position
-> ERROR: Summary function row appears with "no items to show" message
reviewed
83
33853JS016/12/2016ob-view-grid.js985All the variables in a function must be declared on top of the function: http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Variable_Declarationreviewed
84
33626G216/12/20161. Go to the [Unit of Measure] window
2. Create a new record in grid view
3. Cancel the edition.
->ERROR: Summary function row appears
reviewed
85
34725G1316/12/2016BaseReportActionHandlerDo not depend on HashMap if API only requires a Mapreviewed
86
34721G216/12/2016BaseWebServiceServletJSON WS are not supporting stateless requestreviewed
87
34453G216/12/2016HeartbeatProcessMissing exception capturing for the commitAndClose() method alsoreviewed
88
34523J423/12/2016OBSchedulerreviewed
89
34900G1213/01/2017reviewed
90
34977G121/2/2017DefaultJsonDataService.isOrganizationEntityif (b) return true; else return false; -> return breviewed
91
34977G121/2/2017DefaultJsonDataService.isOrganizationEntityif (a && (b)) -> if (a && b)reviewed
92
34977PR01/2/2017DefaultJsonDataService.addWritableAttributedon't check in deactivated orgs if already writablereviewed
93
34977PR01/2/2017DefaultJsonDataService.addWritableAttribute for (String orgId : OBContext.getOBContext().getDeactivatedOrganizations()) {
if (orgId.equals(rowOrganization)) {
writable = true;
break;
}

->

writable = OBContext.getOBContext().getDeactivatedOrganizations().contains(rowOrganization)
reviewed
94
34977G121/2/2017OBContext.getOrganizationList String propertyActive = "N";
if (isActiveOrganization) {
propertyActive = "Y";
}
-> String propertyActive = isActiveOrganization ? "Y":"N";
reviewed
95
35074G173/2/2017ResponseActionsBuilderBeing an abastraction layer, it should not expose implementation detail by throwing JSONExceptionreviewed
96
34824G23/2/2017It is still posible to create record in GL Items with mandatory numeric values (ie. Received In) being empty reviewed
97
35055G23/2/2017In case the button has a list reference and the process definition a "list of buttons", button in window doesn't change label based on selected record value.

Case 1 (list ref, no button list) -> OK
1.1. Follow steps described in issue
1.2. Update in db EM_APRM_AddPayment column to 'B' for created order
1.3. Select it and realize button name is "Orders or Invoices" -> OK

Case 2 (no list ref, button list) -> OK
2.1. Don't set list reference to the button
2.2. In Add Payment process definition add a new parameter
-Reference: Button list
-Ref search key: APR_buttonList
2.3. Follow steps to reproduce and realize the Done button is now named "Submit" -> OK

Case 3 (list ref, button list) -> FAIL
3.1 Follow steps to reproduce described in issue
3.2 Add button list (step 2.2)
3.3 Follow steps to reproduce and realize the Done button is now named "Submit" -> OK
3.4 Follow steps in Case 1 -> FAIL: buttons is named "Add Payment" but expected "Order or Invoices"
NOW IN TRYreviewed
98
35106C610/2/2017UIDefinition.showHoverreviewed
99
35397C803/03/2017XMLEntityConverter.setReadableClientsreviewed
100
35435C110/3/2017reviewed
Loading...