iATS Payment Extension Review (Fall 2017)

	A	B	C	D	E	F
1	Category	Criterion	Priority	Evaluation (Sep/Oct)	Evaluation (Jan)	Comment
2	Admin	Code is licensed under AGPLv3+, GPLv2+, LGPLv2+, MIT/X11, or BSD-2c	Required	Pass
3	Admin	Code is published on github.com	Required	Pass
4	Admin	Extension name uses "org.civicrm.*" namespace	Suggested	Waive		Only a suggested criterion. Difficult to change.
5	Admin	Bus factor >= 2	Suggested	Pass
6	Admin	Access to project is granted to infra team	Suggested	Pass		They already have 2 admins. The project is not in the "civicrm" org, but karing added totten as backup.
7	Admin	Release schedule is aligned with core	Suggested	https://github.com/civicrm/civicrm-core/pull/11052		Retesting every 2 or 3 months
8	Coding	All code complies with civicrm-core style guidelines	Required	WIP	WIP	Run "find -name '*.php' \| xargs civilint" and tweak
9	Coding	Automated tests execute within 3 minutes (or less)	Suggested	Pass
10	Coding	All dependencies are at similar stage (Ex: A stable project should not depend on an experimental project)	Required	Pass
11	Coding	All strings are wrapped in ts()	Required	Pass
12	Coding	The project does not override PHP or TPL files from civicrm-core	Required	WIP	Pass	CRM_Contribute_Form_Task_Invoice. Discussing possibility of removing it and/or phasing it out with a version-check.
13	Coding	The project does not modify the SQL schema of a standard civicrm-core table	Required	Pass
14	Coding	The project does not conflict with other official projects	Suggested	Pass
15	Distribution	The project is packaged as a CiviCRM Extension, Drupal Module, Backdrop Module, Joomla Extension, or WordPress plugin	Required	Pass
16	Distribution	The project has a stable version (1.0+; not alpha or beta)	Required	Pass
17	Distribution	A demo site is provided	Suggested	Waive		There's a semi-private site that Karin/Alan can share with active contributors doing triage. The extension doesn't provide much in the way of new UI's or workflows, so there's not as much need for public demonstration.
18	QA	The project declares, on the in-app extension management screen, the nature of any changes it makes to existing data or functionality.	Required	Pass		Room for improvement - Maybe provide link to slidedeck.
19	QA	The project functions in all CMS's (for CiviCRM Extension)	Suggested	Pass
20	QA	An automated test suite is included	Required	Pass
21	QA	Project is periodically re-validated with newer versions of CiviCRM and compatibility updates are published	Required	Pass
22	QA	All patches are subjected to peer review	Suggested	Pass
23	QA	All patches are subjected automated tests	Required	Pass		Room for improvement -- test.civicrm.org includes this in the matrix. Would be good to add PR testing. Could use more coverage.
24	Support	Documentation is published	Required	Pass		Room for improvement -- there are cool features (like card-swiping) which don't seem to be presented in the "info.xml" (in-app description).
25	Support	Issues are tracked in an open, public issue management system	Required	Pass
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100