1 of 11

Porting Comments

Dhruv Srivastava - Google�Youssef Elghareeb - Google

Alice Kober Sotzek - Google

Confidential + Proprietary

Confidential + Proprietary

2 of 11

Confidential + Proprietary

Confidential + Proprietary

3 of 11

Confidential + Proprietary

Confidential + Proprietary

4 of 11

What are Ported Comments?

  • Comments posted on older patchsets ported over to a newer patchset.
  • Porting comments are not copies of the original comment but the same comment shown at a different location.
  • Comments are ported to all newer patchset and not just the latest.

Confidential + Proprietary

5 of 11

Confidential + Proprietary

6 of 11

Interacting with porting comments

  • Interacting with porting comments is equivalent to interacting with the original comments.
  • Resolving/unresolving ported comments resolves/unresolved original
  • Replying to ported comment creates reply to original comment

Confidential + Proprietary

7 of 11

Which comments are ported over?

  • Unresolved comments.
  • Drafts - Both resolved and unresolved.
  • Resolved comments are not ported over

Confidential + Proprietary

8 of 11

Confidential + Proprietary

9 of 11

Where are ported comments shown?

  • Determine new range on latest ps by mapping it from earlier ps.
  • If range cannot be determined, then add them as File level comments.

Confidential + Proprietary

10 of 11

Confidential + Proprietary

11 of 11

Thanks! Questions?

Documentation

Confidential + Proprietary