squid-1993

Version:

2.6.STABLE20

Bug link:

http://bugs.squid-cache.org/show_bug.cgi?id=1993

Symptom (Failure):
Squid leaks memory.

How it is diagnosed:

Source analysis (we cannot reproduce this failure).

Root Cause:

When http_reply_access deny of an internally generated error page, squid forgot to reclaim the httt->reply, resulting in memory leak.

--- src/client_side.c        27 May 2008 12:49:39 -0000        1.754.2.14

+++ src/client_side.c        20 Jun 2008 21:09:36 -0000

@@ -2933,6 +2933,9 @@ clientHttpReplyAccessCheckDone(int answe

        err = errorCon(page_id, HTTP_FORBIDDEN, http->orig_request);

        storeClientUnregister(http->sc, http->entry, http);

        http->sc = NULL;

+        if (http->reply)

+            httpReplyDestroy(http->reply);

+        http->reply = NULL;

        storeUnlockObject(http->entry);

        http->log_type = LOG_TCP_DENIED;

        http->entry = clientCreateStoreEntry(http, http->request->method,


Is there any log message?:

No.

Can Errlog automatically log?

Yes. Using Errlog-AG’s resource monitoring logging pattern.