ABCDEFGHIJKLMNOPQRSTU
1
Legend49270
2
Done
3
In progress
4
Needs work
5
6
Comment #CommentSuggested resolutionResolutionAssignedFixedCommit
7
240.3Queries in tracker_page hard to readswitch to multiline or use db_select()d6d2f0d
8
240.4comment_num_new should be a methodadd method - see https://drupal.org/node/2097123andypost91bdd22
9
240.5Comment in UserSignatureTest no longer relevantChange commentandypostY7fcee2d
10
240.8FieldEntityTest and HandlerAllTest use \DrupalSwitch to $this->containerandypostYad7bb7d
11
240.9Changes to test dependenciesVerify that this is needed for tests to pass - verified!andypostY
12
259.1Comment constants changedEnsure in issue summary (which contains change notice draft)
13
259.3Upgrade test for settingsEnsure comment settings moved to instance in upgradeY
14
266.2Node::comment removedEnsure in issue summary (which contains change notice draft)
15
266.6Unintended change to RowPluginTest?Verify intent of change and if not required - revertedandypostY17f7a09
16
266.10Use constant for promotedRemove integrer, use constant - no more relevantandypostY
17
266.16Comments longer than 80 chars in rdf.moduleFix comments - rewrapped first, second one fineandypostYa4cd498
18
266.19comment_add_default_comment_field to a method of CommentManager serviceAdd to CommentManager service (see 240.4) - done, needs to drop wrapperandypost
19
267.1Add a followup issue for EntityNG changesEntityNG unified in HEAD
20
267.2Comment field added after $edit definedMove call to comment_add_default_comment_field upandypostYbf68b8a
21
267.3$text_file removed from FileFieldWidgetTestInvestigate and revertandypostY1a9fd16
22
267.4Loading of comment module in forum installAlready removedandypostY
23
267.5Loading of comment module in forum uninstallremoved, tests commited 7a360b1andypost7a2caccdad5bac
24
267.6Ref to field_purge_batch needs parensText has been changed since comment, doesn't seem relevant
25
267.7Use of old field accessors in forum.moduleUse new field api methods if possiblec836cd3
26
268.1Move UserCommentTest to CommentEntityTestMove test class to use test entity instead of user entitylarowlana4a6317
27
268.2UserCommentTest has docblock for $modulesRemovelarowlana4a6317
28
268.3UserCommentTest has docblock for getInfoRemovelarowlana4a6317
29
268.4slow CommentExists method in UserCommentTestUse api insteadlarowlana4a6317
30
268.5slow deleteComment method in UserCommentTestUse api insteadlarowlana4a6317
31
268.6redundant 'delete' operation in UserCommentTestRemovelarowlana4a6317
32
268.7vague function name getUnapprovedComment UserCommentTestRenamelarowlana4a6317
33
268.8use of id in CommentUserTest, non article commentchange to ID and update commentlarowlana4a6317
34
268.9CommentUSerTest::testCommentUser is too genericSplit into multiple methodslarowlana4a6317
35
268.10CommentUSerTest comments not sentence caseFix commentslarowlana4a6317
36
268.11Extra blcnk lines in CommentUSerTestremove larowlana4a6317
37
268.12Incorrect sentence structure in CommentUSerTestFix commentslarowlana4a6317
38
268.13Misleading comment 'Reset' in CommentUserTestFix commentslarowlana4a6317
39
268.14Akward/terse comment in CommentUserTestFix commentslarowlana4a6317
40
268.15Weak assertion regarding H2Check for something else other than h2larowlana4a6317
41
268.16Hyphenated user-commentRemove hyphen, refactorlarowlana4a6317
42
268.18Tests for links, No tests for formRemove tests for links, test form is not present insteadlarowlana4a6317
43
268.19Call to dfac()Revisit and clear something else insteadlarowlana4a6317
44
268.20Clarify test intentAdd 'test user can post but not view' commentc71e955
45
268.21Unneccessary assert messageRemoveandypostY184735c
46
268.23use of \Drupaluse $this->containerandypostY9821b22
47
268.25Improve documentation on propertyDefinitions in CommentItemOut of scope, upstream in HEAD (we have {@inheritdoc})
48
268.26Incorrect logic in comment-wrapper.html.twigChanged in HEAD, no longer relevant
49
271.1Use field.info service instead of field_info_instanceChangeandypost658113c
50
271.2Weirdness in CommentTranslationUITestClarify3533e89
51
271.3Weird createEntity method in CommentTranslationUITestAdd extra comments to clarify3533e89
52
273.2Use field.info service instead of field_info_instance in CommentFieldsTestChanged + replace field_info_field()andypost2e90437
53
273.3New assertions regarding field type in useRemoved in favour of https://drupal.org/node/2031707 Y
54
273.5Changes to numberingVerify - change is valid, added to https://drupal.org/node/2083895
55
273.6Changes to pagerWe changed number of nodes/and behaviour
56
273.8Use of old field accessors in CommentLinksTestFixed8f3964e
57
273.10API changes to comment settings namesEnsure listed in change notice in summary Done
58
274.1RouteSubscriber doc block sentence structureFix comment02fffe8
59
274.2RouteSubscriber intent not clearDocument that the class adds the legacy route if node module enabled23a9a84
60
274.3Missing . on moduleHandler docAdd .andypost2115b12
61
274.4Incorrect @var in moduleHandler docFixandypost2115b12
62
274.5RouteSubscriber doc block is thinFix23a9a84
63
277.1CommentDefaultFormatter and CommentWidget docblock need verbsFixpameeelabeee0cf
64
277.2Why comment_default?Explain to jess that leaves room for others like comment_link etc
65
277.3Wrong sentence case in CommentDefaultFormatterfixpameeelabeee0cf
66
277.4_comment_get_default_statusremoved, needs to check is comment_entity_insert() logic
andyposthttps://drupal.org/node/2031203#comment-7598481
67
277.5Move logic regarding additionsFix logicf146665
68
277.6Comment regarding count needs clarificationClarify that nothing is output if comment count is zero, but admin should always see unpublished where count could be 0pameeela1d0c2a6
69
277.7Messy logic around search view modesSimplify5b68a19
70
277.8inline @see, unclear commentFixdfefaa5
71
277.9$additions isn't clear, comment_add calls out to procedural codeFix $additions to make it clear, inject EntityManagerae033b3
72
277.10USe of 'needed' in commentFix and clarifypameeelabdf6448
73
277.12Unclear comment regarding hiddenbehaviour is in head
74
277.13Unclear reference to $form['advanced']Fix it 0cdc468
75
277.14Unclear comment around collapsing detailsFix commentpameeelabeee0cf
76
277.15Arbitrary weightRemove91d22e9
77
278.1Add a method for reply url to CommentInterfaceAdd method and use itc4be7ee
78
278.2Missing @throws in docblockAdd @throws0c43a6d
79
278.3Unclear comment in render controlelrfixpameeela870ec07
80
278.4Unclear comment in render controlelrfixpameeela4a34032
81
278.5comment_links should be a methodAdd to CommentManager service (see 240.4)fc455bb
82
278.6Unclear comment around REQUEST_TIMfixpameeela4b68311
83
278.7use of refactorCapitalize to Refactorandypost∞
84
278.8Unclear comment around useridfix as per suggestionandypostY5dcdbe4
85
278.9Comment longer than 80 chars in StorageControllerInterfacefixandypostY8c13ae7
86
278.11Rename AdminController, fix missing . and docblockAdded comment and . - not sure it makes sense to renameandypostb6f9c10
87
278.12Missing the from commentsAddandypostYc1bcfe6
88
278.13Ref to CustomBlockremovelarowlan6d6ed5a
89
278.14Clarify intent of overviewFixlarowlan6d6ed5a
90
278.15Rename $field_ui to $field_ui_enabledFixandypostY
91
278.16Lowercase removeChange to RemoveandypostY13ac143
92
278.17Add inline comment hunk for closureAddandypostY4ef8113
93
278.18More inline comments for buidling bundlesAdd4a1a564
94
278.19Check permissions for operationsFix4a1a564
95
278.20manage display|fields -> Manage display|fieldsFixandypostY92e586e
96
278.21Fix comment for bundleInfoCan't find this in file!pameeela
97
278.22Fix comment returnFixlarowlan6d6ed5a
98
278.23Add more inline commentsFixlarowlana0ff262
99
278.24Missing . for doc block make Commentcontroller name more specificFixed in HEAD
100
278.26Fix issue with CommentController doc blockFixandypost489ee99